Fix null-pointer exception in error handling of RunAndWait #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Cmd.Process.Wait` does not guarantee that the `ProcessState` struct it returns is non-nil if the error it returns is non-nil, because we might have an invalid PID or a `waitpid` syscall error (ECHILD or EINTR). We'll check ProcessState struct first b/c it might have the process error code and this is going to be the common case, but if not then we'll bubble-up the error. Expanded test coverage for invalid and pruned an unused error handling branch.
This was referenced Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #255
Cmd.Process.Waitdoes not guarantee that theProcessStatestruct it returns is non-nil if the error it returns is non-nil, because we might have an invalid PID or awaitpidsyscall error (ECHILD or EINTR).We'll check ProcessState struct first b/c it might have the process error code and this is going to be the common case, but if not then we'll bubble-up the error. Expanded test coverage for invalid and pruned an unused error handling branch.
cc @jasonpincin @misterbisson